Move subscription info fetch into Go#334
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves subscription metadata retrieval (e.g., subscription-userinfo and profile-update-interval headers) from the Android/Kotlin service layer into the Go native fetch pipeline, so subscription parsing happens alongside the existing Go-based profile fetch and validation.
Changes:
- Added a new
FetchStatus.Action.SubscriptionInfoevent and extra fields onFetchStatusto carry subscription stats and server-provided update interval. - Updated profile import/update flows to consume the Go-reported subscription info instead of making a separate OkHttp request.
- Removed the service module’s OkHttp dependency and deleted the Kotlin-side subscription header fetch/parser utility.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/profile/src/androidMain/kotlin/com/github/kr328/clash/profile/vm/PropertiesViewModel.kt | Ignores SubscriptionInfo in the progress UI so progress text/state isn’t disturbed by the new status event. |
| service/src/main/kotlin/com/github/kr328/clash/service/util/SubscriptionUserInfo.kt | Removes Kotlin/OkHttp-based subscription header fetching and parsing. |
| service/src/main/kotlin/com/github/kr328/clash/service/ProfileProcessor.kt | Captures SubscriptionInfo from Clash.fetchAndValid and persists subscription fields/update interval when importing/updating profiles. |
| service/src/main/kotlin/com/github/kr328/clash/service/ProfileManager.kt | Drops the additional “updateFlow” subscription refresh that previously performed a separate request. |
| service/build.gradle.kts | Removes OkHttp dependencies from the service module. |
| core/src/main/kotlin/com/github/kr328/clash/core/model/FetchStatus.kt | Extends FetchStatus with subscription fields and a new SubscriptionInfo action. |
| core/src/main/golang/native/config/fetch.go | Extracts subscription headers during config fetch and reports them back to Kotlin via a new SubscriptionInfo status payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the subscription information fetching and parsing from Kotlin/JVM into the Go native layer to reduce redundant network requests, reuse Go-level network stack, and reduce dependency/APK size.
Ports MetaCubeX@8a0e818.